fix: Preserve host application logging configuration#2010
Draft
vdusek wants to merge 2 commits into
Draft
Conversation
…x adaptive-crawler extra
vdusek
added
t-tooling
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2010 +/- ##
=======================================
Coverage 93.35% 93.35%
=======================================
Files 179 179
Lines 12482 12483 +1
=======================================
+ Hits 11652 11654 +2
+ Misses 830 829 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 3, 2026
vdusek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BasicCrawler.__init__(with the defaultconfigure_logging=True) calledconfigure_logger(root_logger, remove_old_handlers=True), wiping the host application's root logging handlers. Embedding Crawlee in a larger app silently removed the host's own logging configuration.Changes
The root logger (and the
httpxlogger) is now configured only when the root logger has no handlers yet, mirroringlogging.basicConfigsemantics. A host that has already configured logging keeps its configuration.Verification
Two regression tests that fail without the fix: one asserts host-installed root handlers survive crawler construction, the other asserts Crawlee still configures an unconfigured root logger.
Behavior change
This intentionally changes observable behavior, since the old behavior was the bug: host apps keep their logging config.